TmfAnalysisElement: Execute analysis in separate thread#64
Draft
bhufmann wants to merge 1 commit intoeclipse-tracecompass:masterfrom
Draft
TmfAnalysisElement: Execute analysis in separate thread#64bhufmann wants to merge 1 commit intoeclipse-tracecompass:masterfrom
bhufmann wants to merge 1 commit intoeclipse-tracecompass:masterfrom
Conversation
Contributor
Author
|
Well, the schedule() call should not block. Calling stateSystem.waitForCompletion() should not be done in the analysis module. The analysis module should be fixed rather than workaround it. For that putting this a draft PR for now. |
This was done in UI thread and if module.schedule blocks due to waitForCompletion (e.g. of dependent analysis) the UI thread blocks until it's finished. Change-Id: I5609f7cc06baf4e4c62c43b4fff3363415e3c1cc Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann
force-pushed
the
analysis-refresh
branch
from
21e2b25 to
5f54e4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done in UI thread and if module.schedule blocks due to waitForCompletion (e.g. of dependent analysis) the UI thread blocks until it's finished.
Signed-off-by: Bernd Hufmann bernd.hufmann@ericsson.com