-
Notifications
You must be signed in to change notification settings - Fork 12
Making the host ip device configurable #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Making the host ip device configurable #29
Conversation
| target.teardown() | ||
| dlt = None | ||
| if target_config.data_router_config: | ||
| dlt = DltReceive( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing with. DltReceive is context manager. In other targets as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed on 94d6916
45b0c8b to
94d6916
Compare
| if target_config.data_router_config: | ||
| dlt = DltReceive( | ||
| target_ip=target_config.ip_address, | ||
| protocol=Protocol.UDP, | ||
| data_router_config=target_config.data_router_config, | ||
| binary_path=test_config.dlt_receive_path, | ||
| ) | ||
| dlt.start_process() | ||
|
|
||
| target = TargetQvp(test_config.ecu, test_config.os) | ||
| target.register_processors(qvp_process) | ||
| yield target | ||
| target.teardown() | ||
| finally: | ||
| if dlt: | ||
| dlt.kill_process() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if target_config.data_router_config: | |
| dlt = DltReceive( | |
| target_ip=target_config.ip_address, | |
| protocol=Protocol.UDP, | |
| data_router_config=target_config.data_router_config, | |
| binary_path=test_config.dlt_receive_path, | |
| ) | |
| dlt.start_process() | |
| target = TargetQvp(test_config.ecu, test_config.os) | |
| target.register_processors(qvp_process) | |
| yield target | |
| target.teardown() | |
| finally: | |
| if dlt: | |
| dlt.kill_process() | |
| if target_config.data_router_config: | |
| dlt = DltReceive( | |
| target_ip=target_config.ip_address, | |
| protocol=Protocol.UDP, | |
| data_router_config=target_config.data_router_config, | |
| binary_path=test_config.dlt_receive_path, | |
| ) | |
| with dlt if dlt else nullcontext(): | |
| target = TargetQvp(test_config.ecu, test_config.os) | |
| target.register_processors(qvp_process) | |
| yield target | |
| target.teardown() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done on e5f27a5
draganbjedov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash related commits and then I can approve.
e5f27a5 to
0af99d8
Compare
Done |
|
@MaciejKaszynski Did you tested this by running ITF tests from |
Locally I get a pass for qnx_qemu image. I used |
|
You need to rebase. We have changed ITF structure #30 |
0af99d8 to
a10f5ea
Compare
host_ip.host_diagnostic_ipoptional configuration field.data_router_configconfiguration field optional so that if nothing is configured no dlt is created.