Replace Bouncy Castle with JCA for SecurityProvider#1645
Draft
kevinherron wants to merge 2 commits intomainfrom
Draft
Replace Bouncy Castle with JCA for SecurityProvider#1645kevinherron wants to merge 2 commits intomainfrom
kevinherron wants to merge 2 commits intomainfrom
Conversation
- Add CipherFactory utility for creating JCA-configured ciphers - Update SecurityAlgorithm to use explicit AlgorithmParameterSpec - Configure RSASSA-PSS with SHA-256 digest and MGF1, 32-byte salt - Configure RSA-OAEP with SHA-256 for hash and MGF1 - Centralize cipher initialization in CipherFactory - Update signature verification to use AlgorithmParameterSpec - Remove inline cipher creation in ChunkEncoder/ChunkDecoder - Remove inline cipher creation in UsernameProvider - Remove inline cipher creation in AbstractIdentityValidator - Remove `bcprov-jdk18on` dependency
- Add a parameterized test covering all SecurityPolicy/MessageSecurityMode combinations - Refactor KeyStoreLoader to support both server and client keystores - Update TestServer to generate endpoints for all security configurations
Contributor
Author
|
I'm going to pause this while I figure out if the existing and upcoming ECC profiles will require me to bring this dependency right back... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed the
bcprov-jdk18on(BouncyCastle Provider) dependency fromstack-core. It is no longer necessary to install a BouncyCastle security provider to use any of the supportedSecurityPolicyvalues.Background
Prior to this change, Eclipse Milo depended on BouncyCastle's provider library (
bcprov-jdk18on) in addition to its PKIX library (bcpkix-jdk18on). The provider dependency was originally needed because certain cryptographic algorithms used by OPC UA security policies were not available in older Java versions' default security providers.However, all cryptographic algorithms required by Milo's supported security policies are now available in modern Java (17+) through the built-in JCA/JCE providers:
RSA/ECB/PKCS1Padding,AES/CBC/NoPadding,HmacSHA1RSA/ECB/OAEPWithSHA-1AndMGF1Padding,AES/CBC/NoPadding,HmacSHA1RSA/ECB/OAEPWithSHA-1AndMGF1Padding,AES/CBC/NoPadding,HmacSHA256RSA/ECB/OAEPWithSHA-1AndMGF1Padding,AES/CBC/NoPadding,HmacSHA256RSA/ECB/OAEPWithSHA-256AndMGF1Padding,AES/CBC/NoPadding,HmacSHA256