Implement UaVariableTypeNodeBuilder for UaVariableTypeNode#1485
Merged
kevinherron merged 3 commits into1.0from Jun 5, 2025
Merged
Implement UaVariableTypeNodeBuilder for UaVariableTypeNode#1485kevinherron merged 3 commits into1.0from
UaVariableTypeNodeBuilder for UaVariableTypeNode#1485kevinherron merged 3 commits into1.0from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new builder pattern for constructing UaVariableTypeNode instances, addressing issue #1484. Key changes include adding the UaVariableTypeNodeBuilder class with methods to set various node properties, builder methods (build, buildAndAdd) for instantiation, and integration of attribute filters and references.
...sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/nodes/UaVariableTypeNode.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the UaVariableTypeNodeBuilder to facilitate the construction and management of UaVariableTypeNode instances, while also standardizing the handling of HasTypeDefinition references.
- Added a builder method and inner builder class in UaVariableTypeNode
- Updated the setTypeDefinition method in both UaVariableTypeNode and UaVariableNode to remove duplicate HasTypeDefinition references
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| opc-ua-sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/nodes/UaVariableTypeNode.java | Introduced the UaVariableTypeNodeBuilder and helper methods to build and add nodes |
| opc-ua-sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/nodes/UaVariableNode.java | Updated setTypeDefinition method to remove existing HasTypeDefinition references |
...sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/nodes/UaVariableTypeNode.java
Outdated
Show resolved
Hide resolved
opc-ua-sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/nodes/UaVariableNode.java
Show resolved
Hide resolved
...sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/nodes/UaVariableTypeNode.java
Outdated
Show resolved
Hide resolved
...sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/nodes/UaVariableTypeNode.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1484