Removal of Dead Code in object_to_xml_element - (Lang_string_set_to_xml)#456
Closed
ZANDx1 wants to merge 6 commits intoeclipse-basyx:mainfrom
Closed
Removal of Dead Code in object_to_xml_element - (Lang_string_set_to_xml)#456ZANDx1 wants to merge 6 commits intoeclipse-basyx:mainfrom
ZANDx1 wants to merge 6 commits intoeclipse-basyx:mainfrom
Conversation
Previously, we did not test that `AASXWrite.write_all_aas_objects` did indeed that: it includes all `Submodel`s inside the given `ObjectStore`. This adds a unittest to `test_aasx_utils` that checks for this expected behavior. Fixes eclipse-basyx#209
…ge (eclipse-basyx#436) adapter.aasx: Add support for loading and saving thumbnails in AASX package Previously, the `AASXReader` did not load the thumbnail in the `read_into` function, instead a separate function needed to be called. This behavior did also occur in `AASXWriter` with writing the thumbnail. This was unintuitive, as it required a separat call of the load/save function. This PR implements the loading/storing of the thumbnail directly in the loading/storing of other supplementary files. Fixes eclipse-basyx#435
…clipse-basyx#434) `adapter.aasx`: Add `rename_file` to `DictSupplementaryFileContainer` Before: There was no supported way to rename supplementary files in `DictSupplementaryFileContainer`. Workflow had to manipulate internals or create duplicates, making file handling error-prone. Now: A public rename operation preserves content de-duplication and resolves name conflicts, simplifying AASX read/write flows and reducing inconsistent mappings.
Previously, multilingual fields (`display_name`, `description`, `MultiLanguageProperty.value`) could be assigned invalid types, leading to inconsistent and sometimes invalid JSON/XML serialization. As a result, this behavior could cause interoperability issues. The AAS specification requires these fields to be of type `LangStringSet / MultiLanguageTextType`. This requirement is now enforced to ensure spec-compliant serialization. Fixes eclipse-basyx#416
Author
|
Wrong branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We decided to remove the call of
lang_string_set_to_xmlcompletely as this specific case inobject_to_xml()is considered Dead code.Because the XML tag for a
LangStringSetvaries based on its context (the tag is determined by the parent's attribute), it must always be called explicitly with a tag parameter by the parent's serialization logic. Since there is no scenario where a LangStringSet is serialized in isolation (It cannot be a standalone xml object), this branch is unreachable and should be removed to maintain code cleanliness.Closes #397