Skip to content

Removal of Dead Code in object_to_xml_element - (Lang_string_set_to_xml) #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZANDx1 wants to merge 3 commits into from
Closed

Removal of Dead Code in object_to_xml_element - (Lang_string_set_to_xml) #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07f47b9
deletion of lang_string_set_to_xml() call
ZANDx1 Jan 19, 2026
b36184d
refactor: remove dead code and fix copyright headers
ZANDx1 Jan 19, 2026
57cf3c8
cleanup: final code adjustments for XML adapter
ZANDx1 Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions sdk/basyx/aas/adapter/xml/xml_serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2025 the Eclipse BaSyx Authors
# Copyright (c) 2026 the Eclipse BaSyx Authors
#
# This program and the accompanying materials are made available under the terms of the MIT License, available in
# the LICENSE file of this project.
Expand Down Expand Up @@ -899,10 +899,6 @@ def object_to_xml_element(obj: object) -> etree._Element:
return value_reference_pair_to_xml(obj)
elif isinstance(obj, model.ConceptDescription):
return concept_description_to_xml(obj)
elif isinstance(obj, model.LangStringSet):
# FIXME: `lang_string_set_to_xml` expects `tag` parameter, `tag` doesn't have default value
# Issue: https://github.com/eclipse-basyx/basyx-python-sdk/issues/397
return lang_string_set_to_xml(obj) # type: ignore[call-arg]
elif isinstance(obj, model.EmbeddedDataSpecification):
return embedded_data_specification_to_xml(obj)
elif isinstance(obj, model.DataSpecificationIEC61360):
Expand Down
2 changes: 1 addition & 1 deletion sdk/basyx/aas/model/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2025 the Eclipse BaSyx Authors
# Copyright (c) 2026 the Eclipse BaSyx Authors
#
# This program and the accompanying materials are made available under the terms of the MIT License, available in
# the LICENSE file of this project.
Expand Down