Merged
Conversation
Contributor
|
I assume the conflicts are because this depends on #425. I'll have a look at it once that PR is closed. |
ZANDx1
force-pushed
the
objectStore-dumping
branch
3 times, most recently
from
678d9b2 to
447f5e2
Compare
ZANDx1
force-pushed
the
objectStore-dumping
branch
from
447f5e2 to
0c66585
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an additional unit test in
test_aasx_utils.pythat verifies the behavior of AASXWriter.write_all_aas_objects with referenced and unreferenced submodels.write_all_aas_objects does indeed include all Submodels. See unittest
As for the docstring, one could leave it as it is as the functions description already explains it.
Closes #209