Skip to content

Conversation

@rozyczko
Copy link
Member

As requested and described by @jfkcooper this is the library implementation of bilayers in EasyReflectometryLib.

Please scrutinize docs\tutorials\simulation\bilayer.ipynb for correctness and API.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

@rozyczko rozyczko requested a review from jfkcooper January 31, 2026 14:02
@rozyczko rozyczko added [scope] enhancement Adds/improves features (major.MINOR.patch) [priority] high Should be prioritized soon labels Jan 31, 2026
@rozyczko rozyczko mentioned this pull request Jan 31, 2026
@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

❌ Patch coverage is 91.47287% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.30%. Comparing base (205db70) to head (fac389f).

Files with missing lines Patch % Lines
src/easyreflectometry/sample/assemblies/bilayer.py 91.40% 0 Missing and 11 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           append_sample     #292      +/-   ##
=================================================
+ Coverage          88.10%   88.30%   +0.20%     
=================================================
  Files                 45       46       +1     
  Lines               2471     2600     +129     
  Branches             288      307      +19     
=================================================
+ Hits                2177     2296     +119     
+ Misses               233      232       -1     
- Partials              61       72      +11     
Flag Coverage Δ
unittests 88.30% <91.47%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyreflectometry/sample/__init__.py 100.00% <100.00%> (ø)
src/easyreflectometry/sample/assemblies/bilayer.py 91.40% <91.40%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[priority] high Should be prioritized soon [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants