Add Lumen compatibility if facades are disabled#195
Open
chrisschaetzlein wants to merge 2 commits intodwightwatson:masterfrom
Open
Add Lumen compatibility if facades are disabled#195chrisschaetzlein wants to merge 2 commits intodwightwatson:masterfrom
chrisschaetzlein wants to merge 2 commits intodwightwatson:masterfrom
Conversation
Remove facades usage for firing events
Remove facades usage for getting the default Validator instance
Owner
|
Unfortunately this breaks all the tests - any idea on how to get the suite back to green when using |
Contributor
Author
|
Hmm... according to the error reported by Travis: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes will allow using this package with Lumen with disabled facades. Tested with the latest 5.5, not sure about older versions.