Conversation
a205d89 to
c50f7f0
Compare
|
For tests, there are three obvious options:
I am leaning towards (2). Thoughts? |
|
@arcondello, I like option (3). Seems simplest (with parameterized) / no new tests needed, covers everything, and can be easily removed when we kill the old ns. |
|
I am not sure I would describe it as easily removed, since you end up doing something like so removing means changing a lot of |
|
Also, we have quite a few tests, test files, and import statements like not just a simple And given python's import caching (and our namespace clone magic), I'm not 100% sure Given all that, (2) might actually be easier. |
|
Yeah, I am actually already halfway through refactoring a lot of that as a separate PR, because we're not really consistent. Worth doing in either case. |
|
Pr mentioned above: #186 |
5a02ddb to
1ccc30d
Compare
Codecov Report
@@ Coverage Diff @@
## main #185 +/- ##
==========================================
+ Coverage 71.23% 71.60% +0.37%
==========================================
Files 26 27 +1
Lines 1585 1606 +21
==========================================
+ Hits 1129 1150 +21
Misses 456 456
Continue to review full report at Codecov.
|
9f0ab77 to
4468c21
Compare
Makes use of the new
dwave.pluginsnamespace introduced with the release of dwave-qiskit-plugin.The old namespaces still work, but now raise a deprecation warning.
Todo: figure out what to do with the tests (which still import from the old namespace), more testing