Can we update the README if no one has time to update the module?#66
Open
sethwoodworth wants to merge 2 commits intodustin:masterfrom
sethwoodworth:master
Open
Can we update the README if no one has time to update the module?#66sethwoodworth wants to merge 2 commits intodustin:masterfrom sethwoodworth:master
sethwoodworth wants to merge 2 commits intodustin:masterfrom
sethwoodworth:master
Conversation
… with the Github v3 API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not trying to be passive aggressive either, but as per issue #64, this module doesn't work with the github v3 api. I wasted some time today trying to use this repo, not checking open issues first. I would have saved some time if the README had mentioned that the module does not work as-is. I've added a short message to the start of the README, and I am happy to edit it as need be.