Events: instance/job reachability and health #3482
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new events: - Job became reachable/unreachable - Instance became reachable/unreachable - Instance health changed Also create every instance with `unreachable` initially set to `True`. Previously, it used to be set to `False` on instance creation and soon flipped to `True` when starting provisioning, which would result in an unnecessary and potentially misleading event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new events:
Also create every instance with
unreachableinitially set to
True. Previously, it used to beset to
Falseon instance creation and soonflipped to
Truewhen starting provisioning,which would result in an unnecessary and
potentially misleading event.
#3290