Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there ! I've been testing the demo project and I've had to make some changes to make it work:
There are some incompatibilities with the current version of docker mysql image on the docker-compose.yml. When run composer up the console outputs something like this:
I've had to remove the MYSQL_USER variable for it to work. Note that you may need to delete the current container if you want to reproduce it.
Add this command to docker-compose-build.sh script might be a good idea.
On the other hand, a definition of env_file is missing in driftphp_demo_tiny balancer, however I have not been able to make it work with my current version of docker-compose, I have needed to put the .env file in the docker-compose directory:
Thanks to the team for the fantastic work.
Cheers