Fix for openssl checks not picking up CFLAGS being provided by pkg-co…#264
Open
mauritium wants to merge 1 commit intodovecot:mainfrom
Open
Fix for openssl checks not picking up CFLAGS being provided by pkg-co…#264mauritium wants to merge 1 commit intodovecot:mainfrom
mauritium wants to merge 1 commit intodovecot:mainfrom
Conversation
Contributor
|
Why is this needed? lib-ssl-iostream/Makefile.am and lib-dcrypt/Makefile.am already uses $SSL_CFLAGS. Is it needed elsewhere still? I'm thinking better to use it only in the places needing it rather than everywhere. |
Contributor
|
Oh, right, this is just used in the ssl.m4 checks. So basically it's moving the CFLAGS code earlier. But you should also then remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
CFLAGSfor openssl would be delivered bypkg-config, this would not get picked up by the subsequent test, andconfigurewould still posit that it could not find openssl. Now explicitly settingCFLAGSin time for the compile test.