Make solr-config-9.xml compatible with Solr 9.8.0#238
Open
samangh wants to merge 1 commit intodovecot:mainfrom
Open
Make solr-config-9.xml compatible with Solr 9.8.0#238samangh wants to merge 1 commit intodovecot:mainfrom
samangh wants to merge 1 commit intodovecot:mainfrom
Conversation
6 tasks
polarathene
reviewed
Mar 29, 2025
Author
|
@polarathene Thanks for the feedback. I've modified the PR to include setting of the environment variable as another option. Also changed commit title reflect the correct SOLR version (9.8.0) that introduces this change. |
samangh
changed the title
Changes: * remove `numVersionBuckets` which is obsolete and ignored' * remove `<lib ..>`, and instead leave a comment for user to enable modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solr 9.8.1 has one breaking change, which this commit fixes. In Solr
<lib/>directives have been made into an "opt-in" feature in must be explicitly enabled if desired. Unless this is done (or a better alternative is used), the dovecot provided config will fail. See https://solr.apache.org/guide/solr/latest/upgrade-notes/major-changes-in-solr-9.html#configuration-2This PR removes the
<lib/>directives, and leaves a comment for a use to enable the the appropriate Solr module instead. This is one of the recommended fixes by Solr.This comment also removes the
numVersionBucketswhich is obsolete and ignored.