Move shared interfaces into @dotnet/vscode-dotnet-runtime-types#2556
Draft
nagilson wants to merge 2 commits intodotnet:mainfrom
Draft
Move shared interfaces into @dotnet/vscode-dotnet-runtime-types#2556nagilson wants to merge 2 commits intodotnet:mainfrom
nagilson wants to merge 2 commits intodotnet:mainfrom
Conversation
Adds a new types package, `@dotnet/vscode-dotnet-runtime-types`. The intention of this is to prevent consumers from having to copy paste our types. This is quite antiquated and a relic of the prototype of the extension from very long ago. There are now way more types to export and much higher functionality/usage. The @dotnet org already exists for holding packages owned by @dotnet, though it is underutilized. The @types/ repo is intended for JS libraries where the owners don't own the types. Whether we could do something simpler like @dotnet/types is interesting, or if it should be it's own org like @vscode-dotnet-runtime/types but I think it makes sense to group it in an accessible /discoverable space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new types package,
@dotnet/vscode-dotnet-runtime-types.The intention of this is to prevent consumers from having to copy paste our types. This is quite antiquated and a relic of the prototype of the extension from very long ago. There are now way more types to export and much higher functionality/usage. There's a bunch of code which just hard copies our types which makes me and probably the other devs big sad.
The @/dotnet org already exists for holding packages owned by @/dotnet, though it is underutilized.
The @types/ repo is intended for JS libraries where the owners don't own the types.
Whether we could do something simpler like @dotnet/types is interesting, or if it should be it's own org like @vscode-dotnet-runtime/types but I think it makes sense to group it in an accessible /discoverable space.