Auto-generate crc64 package name when package is empty in XmlImporter #1376
+195
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user uses [Register("CustomView")] without a package prefix, the
XmlImporter now auto-generates a crc64 package name from the partial
assembly qualified name. This restores the previous .NET 9 behavior where
Java types with empty package names could still be built.
Fixes dotnet/android#10653
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix java-interop behavior for blank package in XML files
Auto-generate crc64 package name when package is empty in XmlImporter
Jan 23, 2026
...p.Tools.JavaCallableWrappers/Java.Interop.Tools.JavaCallableWrappers.Adapters/XmlImporter.cs
Show resolved
Hide resolved
…ing crc64 logic Added new GetPackageName(string ns, string assemblyName) overload to JavaNativeTypeManager and refactored existing overloads to use it. XmlImporter now uses this new method instead of duplicating the logic. Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
....Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR fixes a build failure in .NET 10 when using [Register("CustomView")] without a package prefix. The fix auto-generates a CRC64-based package name from the assembly-qualified type name when the package attribute is empty or missing in XML type definitions.
Changes:
- Added a new public
GetPackageName(string ns, string assemblyName)method toJavaNativeTypeManagerto centralize package name generation logic - Refactored existing package name generation methods to use the new centralized method, reducing code duplication
- Enhanced
XmlImporterto auto-generate package names when they're missing or empty
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| XmlImporterTests.cs | Comprehensive test suite covering package name generation for empty, missing, and explicit package scenarios, including edge cases like nested types and types without namespaces |
| JavaNativeTypeManager.cs | Adds new public method for package name generation and refactors existing overloads to use it, reducing code duplication while maintaining backward compatibility |
| XmlImporter.cs | Implements auto-generation of package names when missing/empty by parsing assembly-qualified names and delegating to JavaNativeTypeManager |
...Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers/XmlImporterTests.cs
Show resolved
Hide resolved
…ingPolicy Following the pattern used in JavaNativeTypeManagerTests, save and restore the PackageNamingPolicy to prevent test interference if other tests modify this static property. Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
jonathanpeppers
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Register("CustomView")]is used without a package prefix, the build fails becauseXmlImporterdoesn't auto-generate a package name[Register("CustomView"]android#10717 and issue Register Attribute breaks build android#10653XmlImporter.csto auto-generate a package name when package is empty/missingGetPackageName(string ns, string assemblyName)overload toJavaNativeTypeManagerfor reuseGetPackageNameoverloads to use the new methodSummary
This PR fixes the issue where using
[Register("CustomView")]without a package prefix would cause the build to fail in .NET 10. The fix auto-generates a package name from the partial assembly qualified name when the package attribute is empty or missing in the XML.Changes
JavaNativeTypeManager.GetPackageName(string ns, string assemblyName)public method that centralizes package name generation logicGetPackageName(Type)andGetPackageName(TypeDefinition, IMetadataResolver)to use the new methodXmlImporter.GeneratePackageFromAssemblyQualifiedNameto use the new method instead of duplicating crc64 logicOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.