Azure Split - Step 2 - New Files #3904

paulmedynski · 2026-01-20T19:52:31Z

Description

This PR contains the new Abstractions and Azure package files:

Added the new Abstractions and Azure source files and associated pipeline files.
Setup build.proj targets and default version numbers.
Standardized project CLS compliance.

PR series:

Azure Split - Step 1 - Prep Work #3902:
- Merge changes that aren't directly related to the Azure split work, but that setup the stage for that work.
Azure Split - Step 2 - New Files #3904:
- Merge new files and related changes that do not affect the existing MDS projects or artifacts.
Azure Split - Step 3 - Tie Everything Together #3908:
- Merge the changes to MDS and pipelines that tie everything together.
Azure Split - Step 4 - Cleanup #3917:
- Any remaining tasks or cleanup.

Testing

Normal PR/CI pipeline runs will validate most changes.
Manual inspection of pipeline logs and artifacts will confirm some of the fiddly parts.

Copilot

Pull request overview

This pull request is Step 2 of the Azure split effort, adding new Abstractions and Azure extension packages to decouple Azure dependencies from the main Microsoft.Data.SqlClient package. The PR introduces two new packages with their source code, tests, documentation, and CI/CD pipeline configurations while standardizing CLS compliance across projects.

Changes:

Added new Microsoft.Data.SqlClient.Extensions.Abstractions package with base types for authentication and related abstractions
Added new Microsoft.Data.SqlClient.Extensions.Azure package containing Azure authentication implementations moved from MDS
Standardized CLS compliance by using AssemblyAttribute declarations instead of embedded assembly attributes
Added comprehensive CI/CD pipeline support for building and testing both new packages across multiple platforms

Reviewed changes

Copilot reviewed 69 out of 69 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
tools/targets/GenerateThisAssemblyCs.targets	Simplified to unconditionally generate ThisAssembly.cs with configurable namespace
tools/props/Versions.props	Added imports for Abstractions and Azure version properties
src/Microsoft.Data.SqlClient/tests/tools/TDS/*/.csproj	Removed ClsCompliant property (standardization)
src/Microsoft.Data.SqlClient/**/Microsoft.Data.SqlClient.csproj	Added CLS compliance via AssemblyAttribute
src/Microsoft.Data.SqlClient.sln	Added folder structure and projects for Abstractions and Azure packages
src/Microsoft.Data.SqlClient.Extensions/Abstractions/**	Complete Abstractions package with source, tests, and documentation
src/Microsoft.Data.SqlClient.Extensions/Azure/**	Complete Azure package with source, tests, and documentation
eng/pipelines/**	New CI/CD stages, jobs, and variables for building/testing new packages
build.proj	Added targets for building Abstractions and Azure packages
Directory.Packages.props	Added package version management for new packages
BUILDGUIDE.md	Updated documentation with new build targets

src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProviderException.cs

src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProviderInternal.cs

src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs

eng/pipelines/common/templates/jobs/run-tests-package-reference-job.yml

eng/pipelines/libraries/build-variables.yml

eng/pipelines/dotnet-sqlclient-ci-core.yml

src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.cs

src/Microsoft.Data.SqlClient/tests/tools/TDS/TDS.Servers/TDS.Servers.csproj

src/Microsoft.Data.SqlClient.sln

tools/targets/GenerateThisAssemblyCs.targets

Copilot

Pull request overview

Copilot reviewed 72 out of 72 changed files in this pull request and generated no new comments.

codecov · 2026-01-21T17:14:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.52%. Comparing base (88de2b9) to head (74587f9).
⚠️ Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (88de2b9) and HEAD (74587f9). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (88de2b9) HEAD (74587f9)

addons 1 0

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3904      +/-   ##
==========================================
- Coverage   74.93%   67.52%   -7.41%     
==========================================
  Files         269      263       -6     
  Lines       43247    66191   +22944     
==========================================
+ Hits        32407    44696   +12289     
- Misses      10840    21495   +10655

Flag	Coverage Δ
addons	`?`
netcore	`67.50% <ø> (-7.49%)`	⬇️
netfx	`66.54% <ø> (-7.62%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 72 out of 72 changed files in this pull request and generated 3 comments.

src/Microsoft.Data.SqlClient.Extensions/Azure/src/Azure.csproj

eng/pipelines/stages/build-azure-package-ci-stage.yml

src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs

.github/workflows/codeql.yml

eng/pipelines/sqlclient-pr-package-ref-pipeline.yml

src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs

Copilot

Pull request overview

Copilot reviewed 72 out of 72 changed files in this pull request and generated 8 comments.

.github/workflows/codeql.yml

src/Microsoft.Data.SqlClient.Extensions/Azure/test/StringExtensions.cs

src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProvider.Internal.cs

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProviderException.cs

eng/pipelines/sqlclient-pr-project-ref-pipeline.yml

eng/pipelines/sqlclient-pr-package-ref-pipeline.yml

.github/workflows/codeql.yml

- Added the new Abstractions and Azure source files and associated pipeline files. - Setup build.proj targets and default version numbers. - Standardized project CLS compliance.

- Added ThisAssembly generation to Abstractions. - Fixed branch wildcards in PR pipeline and CodeQL workflow triggers.

- Fixed paratemer name typo.

- Fixed cyclic dependency.

- Inhibited some Azure tests that won't pass yet. - Addressed Copilot comments in the PR.

- Addressed Copilot suggestions.

- Fixed a couple of rebase artifacts.

Copilot

Pull request overview

Copilot reviewed 72 out of 72 changed files in this pull request and generated 5 comments.

src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs

eng/pipelines/sqlclient-pr-project-ref-pipeline.yml

tools/targets/GenerateThisAssemblyCs.targets

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProviderException.cs

src/Microsoft.Data.SqlClient.Extensions/Azure/test/StringExtensions.cs

mdaigle

One required change. Others are suggestions for future.

src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs

eng/pipelines/jobs/pack-azure-package-ci-job.yml

eng/pipelines/jobs/test-azure-package-ci-job.yml

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProvider.cs

benrr101

Most of my comments are probably unactionable today, but I'd at least like to see some todo's added to address them later.

eng/pipelines/libraries/build-variables.yml

benrr101 · 2026-01-29T19:06:45Z

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationToken.cs

+    public DateTimeOffset ExpiresOn { get; }
+
+    /// <include file='../doc/SqlAuthenticationToken.xml' path='docs/members[@name="SqlAuthenticationToken"]/ctor/*'/>
+    public SqlAuthenticationToken(


Constructors go before properties

eng/pipelines/jobs/test-azure-package-ci-job.yml

benrr101 · 2026-01-29T19:13:21Z

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProvider.Internal.cs

The paradigm I've implemented for partial is the files should have a . between the class and the contents of the partial (see SqlCommand for example)
Ideally the block comment for the class should have a tag to explain what's in this particular partial. But if that interferes with the official docs, no worries about omitting it.

benrr101 · 2026-01-29T19:15:10Z

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProviderInternal.cs

+                    as SqlAuthenticationProvider;
+            }
+            catch (Exception ex)
+            when (ex is InvalidOperationException ||


For this, you an do ex is Abc or Def or Ghi I usually format multiline ones as

ex is Abc or Def or Ghi

benrr101 · 2026-01-29T19:53:40Z

src/Microsoft.Data.SqlClient.Extensions/Azure/test/DefaultAuthProviderTests.cs

+        // via Theory data so that we detect any new methods that don't meet
+        // our expectations.
+        foreach (var method in
+            #if NET


I know it's a nit but I reaaaaaaaaaaly hate precompiler directives within a line. Can we move this to a variable and use the variable in the foreach?

benrr101 · 2026-01-29T20:01:03Z

src/Microsoft.Data.SqlClient.Extensions/Azure/test/DefaultAuthProviderTests.cs

+    // methods of the SqlAuthenticationProvider class in the Abstractions
+    // package.  We're testing this here because this test project uses both of
+    // those packages, and this is a convenient place to put such a test.
+    [Fact]


I'm having a hard time describing what I think it wrong with this test, but something feels off... I'm wondering if this could be a theory, I'm wondering what's the disconnect between testingn every enum value while having only the AAD providers in the list, I'm wondering whether we expect to ever get an enum value outside that list or a provider that is isn't ours when running this test.

I think this test will end up living in a new MDS test project specifically for testing auth provider integration. I will make a note of that.

benrr101 · 2026-01-29T20:02:49Z

src/Microsoft.Data.SqlClient.Extensions/Azure/test/StringExtensions.cs

+/// </summary>
+internal static class StringExtensions
+{
+    internal static bool Empty(this string str)


I will argue this should be "IsEmpty".

Unless you actually want to "empty" the string and just royally messed up the implementation 😉

It's just string::empty() in C++, which I prefer. But I guess C# folks like verbs 😄

tools/targets/GenerateThisAssemblyCs.targets

- Addressed comments/suggestions in the PR.

- Trying to fix shell argument quoting for --filter.

Copilot

Pull request overview

Copilot reviewed 72 out of 72 changed files in this pull request and generated 2 comments.

src/Microsoft.Data.SqlClient.Extensions/Abstractions/README.md

Copilot AI review requested due to automatic review settings January 20, 2026 19:52

paulmedynski added the Area\Azure Connectivity Use this to tag issues that are related to Azure connectivity. label Jan 20, 2026

This was referenced Jan 20, 2026

[DO NOT MERGE] Visuazlie diffs of feat/azure split #3901

Closed

Azure Split - Step 1 - Prep Work #3902

Merged

paulmedynski added this to the 7.0.0-preview4 milestone Jan 20, 2026

Copilot started reviewing on behalf of paulmedynski January 20, 2026 19:55 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

paulmedynski commented Jan 20, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 21, 2026 11:10

Copilot started reviewing on behalf of paulmedynski January 21, 2026 11:10 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

paulmedynski marked this pull request as ready for review January 21, 2026 17:47

paulmedynski requested a review from a team as a code owner January 21, 2026 17:47

Copilot AI review requested due to automatic review settings January 21, 2026 17:47

paulmedynski changed the title ~~[DRAFT] Azure Split - Step 2 - New Files~~ Azure Split - Step 2 - New Files Jan 21, 2026

Copilot started reviewing on behalf of paulmedynski January 21, 2026 17:48 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

paulmedynski commented Jan 21, 2026

View reviewed changes

.github/workflows/codeql.yml Show resolved Hide resolved

eng/pipelines/sqlclient-pr-package-ref-pipeline.yml Show resolved Hide resolved

src/Microsoft.Data.SqlClient.Extensions/Azure/src/ActiveDirectoryAuthenticationProvider.cs Show resolved Hide resolved

paulmedynski mentioned this pull request Jan 22, 2026

Azure Split - Step 3 - Tie Everything Together #3908

Open

Copilot AI review requested due to automatic review settings January 27, 2026 15:03

Copilot started reviewing on behalf of paulmedynski January 27, 2026 15:04 View session

Copilot AI reviewed Jan 27, 2026

View reviewed changes

paulmedynski mentioned this pull request Jan 27, 2026

Azure Split - Step 4 - Cleanup #3917

Open

Base automatically changed from dev/paul/azure/step1 to main January 29, 2026 18:53

paulmedynski added 5 commits January 29, 2026 15:02

Task 41736: Merge feat/azure-split to main: Step 2 - New files

d549f95

- Added the new Abstractions and Azure source files and associated pipeline files. - Setup build.proj targets and default version numbers. - Standardized project CLS compliance.

Task 41736: Merge feat/azure-split to main: Step 2 - New files

5847d0c

- Added ThisAssembly generation to Abstractions. - Fixed branch wildcards in PR pipeline and CodeQL workflow triggers.

Task 41736: Merge feat/azure-split to main: Step 2 - New files

e369710

- Fixed paratemer name typo.

Task 41736: Merge feat/azure-split to main: Step 2 - New files

d261358

- Fixed cyclic dependency.

Task 41736: Merge feat/azure-split to main: Step 2 - New files

0fbe3e2

- Inhibited some Azure tests that won't pass yet. - Addressed Copilot comments in the PR.

Task 41736: Merge feat/azure-split to main: Step 2 - New files

18ac28b

- Addressed Copilot suggestions.

paulmedynski force-pushed the dev/paul/azure/step2 branch from 30140f6 to 18ac28b Compare January 29, 2026 19:07

Task 41736: Merge feat/azure-split to main: Step 2 - New files

d66586e

- Fixed a couple of rebase artifacts.

Copilot AI review requested due to automatic review settings January 29, 2026 19:12

Copilot started reviewing on behalf of paulmedynski January 29, 2026 19:12 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

mdaigle requested changes Jan 29, 2026

View reviewed changes

benrr101 requested changes Jan 29, 2026

View reviewed changes

priyankatiwari08 self-assigned this Jan 30, 2026

paulmedynski added 2 commits January 30, 2026 10:42

Task 41736: Merge feat/azure-split to main: Step 2 - New files

8cc25d9

- Addressed comments/suggestions in the PR.

Task 41736: Merge feat/azure-split to main: Step 2 - New files

74587f9

- Trying to fix shell argument quoting for --filter.

Copilot AI review requested due to automatic review settings January 30, 2026 14:55

Copilot started reviewing on behalf of paulmedynski January 30, 2026 14:55 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

src/Microsoft.Data.SqlClient.Extensions/Abstractions/README.md Show resolved Hide resolved

src/Microsoft.Data.SqlClient.Extensions/Abstractions/README.md Show resolved Hide resolved

mdaigle approved these changes Jan 30, 2026

View reviewed changes

Azure Split - Step 2 - New Files #3904

Are you sure you want to change the base?

Azure Split - Step 2 - New Files #3904

Uh oh!

Conversation

paulmedynski commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

codecov bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdaigle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulmedynski commented Jan 20, 2026 •

edited

Loading

codecov bot commented Jan 21, 2026 •

edited

Loading