Services filter fixed. And service operations now throws dockerapiexc…#358
Open
n7on wants to merge 4 commits intodotnet:masterfrom
Open
Services filter fixed. And service operations now throws dockerapiexc…#358n7on wants to merge 4 commits intodotnet:masterfrom
n7on wants to merge 4 commits intodotnet:masterfrom
Conversation
|
|
jterry75
reviewed
Nov 19, 2018
jterry75
reviewed
Nov 19, 2018
jterry75
reviewed
Nov 19, 2018
jterry75
reviewed
Nov 19, 2018
jterry75
reviewed
Nov 19, 2018
jterry75
suggested changes
Nov 19, 2018
Contributor
jterry75
left a comment
jterry75
left a comment
There was a problem hiding this comment.
Hey thanks! This looks good to me just a few comments.
…de null as default. New dockerswarmexception added
jterry75
reviewed
Nov 21, 2018
jterry75
reviewed
Nov 21, 2018
jterry75
suggested changes
Nov 21, 2018
Contributor
jterry75
left a comment
jterry75
left a comment
There was a problem hiding this comment.
Ok two last comments and then I think we are good. This looks great
Contributor
|
Change looks great. Just want to see if we can make than delegate an instance method or not and we can merge. |
Contributor
|
@galvesribeiro - PTAL |
Member
|
@dud380 can you please rebase on master so we can merge it and make a new release Today? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swarm operations throw DockerApiException on error.
Service filter bug fixed
Tests updated
Tests added for service operations