feat: add optional iOS BLE restoration subspec and config plugin options#1315
Open
sfourdrinier wants to merge 9 commits intodotintent:masterfrom
Open
feat: add optional iOS BLE restoration subspec and config plugin options#1315sfourdrinier wants to merge 9 commits intodotintent:masterfrom
sfourdrinier wants to merge 9 commits intodotintent:masterfrom
Conversation
- Improved null/nil handling in createClient method - Changed dispatch queue from self.methodQueue to dispatch_get_main_queue() - Added null/nil checks for filteredUUIDs and options in startDeviceScan This patch fixes potential crashes when null values are passed from JavaScript to the native iOS implementation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Replaced all yarn commands with pnpm equivalents - Changed package name to @sfourdrinier/react-native-ble-plx - Added missing @expo/config-plugins dependency - Added *.tsbuildinfo to gitignore 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This prevents build errors when publishing to npm 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…reject (#1) - Add DEFAULT_ERROR_CODE = "BlePlxError" constant - Replace all reject(null, ...) calls with reject(DEFAULT_ERROR_CODE, ...) - Prevents NullPointerException in RN 0.81 when errors are surfaced through native bridge Fixes NPE crash that occurs when using react-native-ble-plx with React Native 0.81+ where PromiseImpl.reject now requires a non-null error code parameter. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com>
- Fix Android RN 0.81 NPE with non-null error codes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add missing RestoreStateEvent to BleModule mock - Reset BleManager singleton state between tests - Fix monitor method expectations to match platform-specific behavior (iOS doesn't pass subscriptionType parameter) - All 80 tests now passing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
🤖 Generated with Claude Code