fix(android): remove device from discovered devices cache#1296
Draft
benletchford wants to merge 1 commit intodotintent:masterfrom
Draft
Conversation
…e rediscovered during scans (dotintent#1279)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way
discoveredDevicesis handled is quite suspect.This PR addresses issue #1279 by removing devices from the discovered devices cache in the Android implementation when they're no longer available. This should allow devices that go out of range and then return to be properly rediscovered during subsequent scans. This is a potential fix that needs further testing in various environments to confirm it resolves the issue completely.