Open
Conversation
Pryz
reviewed
May 12, 2024
|
|
||
|
|
||
| def worker(fn: Callable[None, None]) -> Callable[None, None]: | ||
| """Decorator declaring workers that will be started when dipatch.run is called.""" |
Contributor
There was a problem hiding this comment.
Let's add more color about what a worker is to avoid confusion with other frameworks/workflow orchestrator systems which heavily use the same term.
Signed-off-by: Achille Roussel <achille.roussel@gmail.com>
achille-roussel
force-pushed
the
dispatch.worker
branch
from
723e844 to
25bd032
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still work in progress, please leave feedback on the API and behavior.
Things left to do or decide:
dispatch.runstop when a worker returns?.workerin the FastAPI integration as well?