Spotless plugin doesn't work with lombok in Eclipse/VS Code/Cursor #2796
+148
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudSen
reviewed
Dec 25, 2025
| return new ByteBuddy() | ||
| .subclass(Object.class) | ||
| .name(name) | ||
| .defineMethod("augment", name.equals("lombok.core.FieldAugment") ? Object.class : Object.class, Visibility.PUBLIC, Ownership.STATIC) |
There was a problem hiding this comment.
What is the point of name.equals("lombok.core.FieldAugment") ? Object.class : Object.class given that both branches return the same value?
Member
|
i'm trying to fix this up to merge, please don't force-push |
nedtwigg
requested changes
Jan 21, 2026
| } | ||
|
|
||
| dependencies { | ||
| implementation 'net.bytebuddy:byte-buddy:1.18.3' |
Member
There was a problem hiding this comment.
we have a lib and lib-extra division so that lib has no dependencies, and lib-extra gets stuck with the dependency hell.
byte-buddy cannot be a dependency here. I don't fully understand what you're doing here, but you'll have to do it without adding dependencies into lib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2795