Fix crash on blueprint book creation, also refactor get_blueprint#41
Open
sparr wants to merge 2 commits intodewiniaid:masterfrom
Open
Fix crash on blueprint book creation, also refactor get_blueprint#41sparr wants to merge 2 commits intodewiniaid:masterfrom
sparr wants to merge 2 commits intodewiniaid:masterfrom
Conversation
|
I just tried this and it worked for me. |
|
Work's like a charm for me too... |
|
See also #43 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LuaItemStack.active_indexis 1 (not nil or 0) for a brand new empty blueprint book, which led to a crash when that index in the inventory was accessed.While I was in there I also refactored get_blueprint from recursive to iterative.
Fixes #39