Conversation
Contributor
Author
|
@tijno any thoughts on this change? Seems safe and clearly better to me |
Contributor
|
i can review in the morning - keeping caddyfiles in sync has been an issue in the past so reducing duppl files seems sensible. am on mobile and want to look at impact on node setup. will confirm in the morning |
Contributor
Author
|
Thanks! No rush |
Contributor
|
I think there are 2 issues that will break things
Besides that there are a bunch of other differences between the two caddy files - that are worth checking whether if changing them would break setups. However - many of these may be legacy and no longer required. Maybe you could cast your eye over them and let me know. Here is full list of the differences. main Caddy section
connect-src
script-src
style-src
frame-src
Other
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not necessary because the frontend caddyfile has
selfand we no longer recommend theapi.domain.comconfiguration by default.