Snapshot validator entries and block signers#39
Merged
lazynina merged 1 commit intofeature/proof-of-stakefrom Apr 29, 2024
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
lazynina
force-pushed
the
snapshot-validator-entries-and-block-signers
branch
from
144e8fa to
7ae0a61
Compare
lazynina
changed the title
lazynina
force-pushed
the
snapshot-validator-entries-and-block-signers
branch
from
7ae0a61 to
3154c4d
Compare
tholonious
approved these changes
Apr 26, 2024
| blockHashHex := hex.EncodeToString(blockHash[:]) | ||
| qc := block.Header.GetQC() | ||
| blockSigners := []*PGBlockSigner{} | ||
| if !isInterfaceNil(qc) { |
Contributor
There was a problem hiding this comment.
Is this safe? Please make this this works for a PoW block where the header has neither a QC nor an aggregate QC
Member
Author
There was a problem hiding this comment.
yeah this is safe. the isInterfaceNil check returns true for pow blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.