Add LeaderScheduleEntry#12
Merged
lazynina merged 2 commits intofeature/proof-of-stakefrom Feb 16, 2024
Merged
Conversation
This was referenced Feb 15, 2024
Merged
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
lazynina
force-pushed
the
leader-schedule
branch
2 times, most recently
from
6f640ad to
2c86c5a
Compare
superzordon
requested changes
Feb 16, 2024
Collaborator
superzordon
left a comment
superzordon
left a comment
There was a problem hiding this comment.
A few small refactors for code understandability and cleanliness, but otherwise looks good to me!
entries/pkid.go
Outdated
|
|
||
| // Transform the entries into a list of keys to delete. | ||
| keysToDelete := consumer.KeysToDelete(uniqueEntries) | ||
| keysToDelete = consumer.FilterKeysByPrefix(keysToDelete, lib.Prefixes.PrefixSnapshotLeaderSchedule) |
Collaborator
There was a problem hiding this comment.
Suggested change
| keysToDelete = consumer.FilterKeysByPrefix(keysToDelete, lib.Prefixes.PrefixSnapshotLeaderSchedule) | |
| leaderSchedKeysToDelete := consumer.FilterKeysByPrefix(keysToDelete, lib.Prefixes.PrefixSnapshotLeaderSchedule) |
Collaborator
There was a problem hiding this comment.
Just to make it easier in the future to understand how to add support for a different prefix type
entries/pkid.go
Outdated
| // Execute the delete query. | ||
| if _, err := db.NewDelete(). | ||
| Model(&LeaderScheduleEntry{}). | ||
| Where("badger_key IN (?)", bun.In(keysToDelete)). |
Collaborator
There was a problem hiding this comment.
Suggested change
| Where("badger_key IN (?)", bun.In(keysToDelete)). | |
| Where("badger_key IN (?)", bun.In(leaderSchedKeysToDelete)). |
entries/pkid.go
Outdated
| func PkidBatchOperation(entries []*lib.StateChangeEntry, db *bun.DB, params *lib.DeSoParams) error { | ||
| // We check before we call this function that there is at least one operation type. | ||
| // We also ensure before this that all entries have the same operation type. | ||
| glog.Infof("PkidBatchOperation: Putting %d entries into the database", len(entries)) |
Collaborator
There was a problem hiding this comment.
Lets remove this before merging, or if it's necessary for debugging in a deployed environment, just throw a FIXME above it to remove.
lazynina
force-pushed
the
leader-schedule
branch
from
2c86c5a to
f0cc0b0
Compare
superzordon
approved these changes
Feb 16, 2024
lazynina
force-pushed
the
leader-schedule
branch
from
f0cc0b0 to
14e49c4
Compare
lazynina
force-pushed
the
update-block-and-txn-based-on-pos-updates
branch
from
ddeafd4 to
8840576
Compare
lazynina
force-pushed
the
leader-schedule
branch
from
14e49c4 to
ac7621e
Compare
Base automatically changed from
update-block-and-txn-based-on-pos-updates
to
feature/proof-of-stake
February 16, 2024 21:03
lazynina
force-pushed
the
leader-schedule
branch
from
ac7621e to
83c472d
Compare
This was referenced Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.