Skip to content

Conversation

@FilipPyrek
Copy link
Contributor

@FilipPyrek FilipPyrek commented Jan 18, 2026

Summary by CodeRabbit

  • Chores
    • Updated minimum Python version requirement from 3.9 to 3.10
    • Updated supported Python versions to include 3.10, 3.11, 3.12, and 3.13
    • Updated CI/CD pipelines and test environments to reflect new Python version matrix
    • Simplified and unified dependency constraints across platform-specific configurations

✏️ Tip: You can customize this high-level summary in your review settings.

@linear
Copy link

linear bot commented Jan 18, 2026

@github-actions
Copy link

github-actions bot commented Jan 18, 2026

📦 Python package built successfully!

  • Version: 1.2.2.dev3+e5b18fa
  • Wheel: deepnote_toolkit-1.2.2.dev3+e5b18fa-py3-none-any.whl
  • Install:
    pip install "deepnote-toolkit @ https://deepnote-staging-runtime-artifactory.s3.amazonaws.com/deepnote-toolkit-packages/1.2.2.dev3%2Be5b18fa/deepnote_toolkit-1.2.2.dev3%2Be5b18fa-py3-none-any.whl"

@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.27%. Comparing base (4d76844) to head (c61408e).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   73.27%   73.27%           
=======================================
  Files          93       93           
  Lines        5193     5193           
  Branches      757      757           
=======================================
  Hits         3805     3805           
  Misses       1144     1144           
  Partials      244      244           
Flag Coverage Δ
combined 73.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

Python 3.9 support is being dropped across the project. The minimum supported version shifts to Python 3.10, affecting CI/CD workflows (GitHub Actions), local development (noxfile), package metadata (pyproject.toml), and documentation. All Python 3.9-specific conditional logic, classifiers, and dependency pins have been removed or consolidated, with the supported matrix now spanning 3.10 through 3.13.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title clearly and concisely summarizes the main change: removing Python 3.9 support across the entire codebase.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
pyproject.toml (1)

57-59: Redundant duckdb constraints.

Lines 57-58 have identical version ranges. Consider consolidating:

-    "duckdb>=1.1.0,<2.0.0; python_version < '3.12'",
-    "duckdb>=1.1.0,<2.0.0; python_version >= '3.12'",
+    "duckdb>=1.1.0,<2.0.0; python_version < '3.13'",
     "duckdb>=1.4.1,<2.0.0; python_version >= '3.13'",

@deepnote-bot
Copy link

🚀 Review App Deployment Started

📝 Description 🌐 Link / Info
🌍 Review application ra-59
🔑 Sign-in URL Click to sign-in
📊 Application logs View logs
🔄 Actions Click to redeploy
🚀 ArgoCD deployment View deployment
Last deployed 2026-01-20 16:36:20 (UTC)
📜 Deployed commit 115e2d9c64c4719ed44a70e56dbb810a8f165fcc
🛠️ Toolkit version e5b18fa

@FilipPyrek FilipPyrek marked this pull request as ready for review January 20, 2026 16:43
@FilipPyrek FilipPyrek requested a review from a team as a code owner January 20, 2026 16:43
@FilipPyrek FilipPyrek requested a review from m1so January 20, 2026 16:43
@FilipPyrek
Copy link
Contributor Author

Related PR: deepnote/environments#65

@FilipPyrek FilipPyrek requested a review from mfranczel January 20, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants