-
Notifications
You must be signed in to change notification settings - Fork 3
feat: remove python 3.9 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: remove python 3.9 #59
Conversation
|
📦 Python package built successfully!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage 73.27% 73.27%
=======================================
Files 93 93
Lines 5193 5193
Branches 757 757
=======================================
Hits 3805 3805
Misses 1144 1144
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
📝 WalkthroughWalkthroughPython 3.9 support is being dropped across the project. The minimum supported version shifts to Python 3.10, affecting CI/CD workflows (GitHub Actions), local development (noxfile), package metadata (pyproject.toml), and documentation. All Python 3.9-specific conditional logic, classifiers, and dependency pins have been removed or consolidated, with the supported matrix now spanning 3.10 through 3.13. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pyproject.toml (1)
57-59: Redundant duckdb constraints.Lines 57-58 have identical version ranges. Consider consolidating:
- "duckdb>=1.1.0,<2.0.0; python_version < '3.12'", - "duckdb>=1.1.0,<2.0.0; python_version >= '3.12'", + "duckdb>=1.1.0,<2.0.0; python_version < '3.13'", "duckdb>=1.4.1,<2.0.0; python_version >= '3.13'",
|
🚀 Review App Deployment Started
|
|
Related PR: deepnote/environments#65 |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.