This repository was archived by the owner on Jan 21, 2026. It is now read-only.
Updated initailize flag #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-Baji
approved these changes
Mar 28, 2022
A-Baji
reviewed
Mar 29, 2022
A-Baji
reviewed
Mar 29, 2022
A-Baji
reviewed
Mar 29, 2022
A-Baji
reviewed
Mar 29, 2022
A-Baji
reviewed
Mar 29, 2022
A-Baji
reviewed
Mar 29, 2022
Author
|
These changes have been pushed! @A-Baji please review at your convenience! |
guzman-raphael
suggested changes
Mar 31, 2022
Collaborator
guzman-raphael
left a comment
guzman-raphael
left a comment
There was a problem hiding this comment.
@zitrosolrac Good effort! 👏
However, I think there may be a better place to put the initial run.
otumat/watch.py
Outdated
Comment on lines
14
to
18
| if watch_init: | ||
| self.watch_args = subprocess.Popen( | ||
| [self.watch_script, *self.watch_args], | ||
| stdout=subprocess.PIPE).communicate()[0].decode('utf-8').split('\n')[:-1] | ||
|
|
Collaborator
There was a problem hiding this comment.
Hmm, I'm not sure if this is in the right place. It may be better to put this within run as we normally preserve state in the watch_args associated with the Handler.
Author
|
@guzman-raphael your changes have been implemented please review at your convenience. thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.