Skip to content

fix(cli): remove api-key logging #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinlin09 merged 1 commit into from
Jan 21, 2026
Merged

fix(cli): remove api-key logging #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions dashscope/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,7 @@ class Oss:
@classmethod
def upload(cls, args):
print(
f"Start oss.upload: model={args.model}, file={args.file}, "
f"api_key={args.api_key}",
f"Start oss.upload: model={args.model}, file={args.file}",
)
Comment on lines 227 to 229
Copy link

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider replacing print with the logging module for CLI output. Using a logger is a best practice that offers more flexibility, such as configurable log levels (INFO, DEBUG, ERROR), formatting, and routing output to different destinations like files or stderr. While this would be a broader change across the file, starting here would improve the tool's maintainability.

if not args.file or not args.model:
print("Please specify the model and file path")
Expand Down