feat(ci): add unit tests

[kevinlin09]

Description

[Describe what this PR does and why]

Related Issue: Fixes #[issue_number] or Relates to #[issue_number]

Security Considerations: [Check if API keys or sensitive credentials are exposed in code/logs]

Type of Change

• Bug fix
• New feature
• Breaking change
• Documentation
• Refactoring

Component(s) Affected

• Model
• Application
• Common
• Documentation
• Tests
• CI/CD

Checklist

• Pre-commit hooks pass
• Tests pass locally
• Documentation updated (if needed)
• Ready for review

Testing

[How to test these changes]

Additional Notes

[Optional: any other context]

[gemini-code-assist]

Summary of Changes

Hello @kevinlin09, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the maintainability and quality of the test suite. It involves a significant restructuring of the test directory, moving existing tests from a 'legacy' folder to a 'unit' folder, alongside numerous code style and readability improvements. These changes aim to standardize the test codebase, address linting warnings, and improve the clarity of test assertions, ultimately contributing to a more robust and easier-to-manage testing environment.

Highlights

• Test File Restructuring: All existing test files previously located in the tests/legacy directory have been moved to a new tests/unit directory, standardizing the test suite's organization.
• Code Readability Improvements: Numerous long string literals, especially those containing JSON data or multi-line text, have been refactored into multi-line expressions using parentheses to enhance readability and adhere to style guidelines.
• Pythonic Iteration Updates: Loops iterating over lists by index (e.g., for i in range(len(list)): assert list[i].attr) have been updated to use the more Pythonic for i, item in enumerate(list): assert item.attr pattern.
• Linting and Type Hinting Adjustments: Various pylint: disable comments and type: ignore hints have been added to address specific linting warnings and type checking issues, improving code quality and static analysis compliance.
• Simplified Conditional Logic: The phrases function in test_asr_phrases.py has been refactored to simplify its conditional flow, making it more concise and easier to understand.
• Improved File Handling: File reading operations, such as loading JSON data, have been updated to use with open(...) as f: constructs, ensuring proper resource management.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily focuses on refactoring the test suite. Key changes include renaming test files from the legacy directory to unit, improving code formatting for better readability (e.g., breaking long lines), and adopting more Pythonic constructs like with statements for file handling and enumerate for loops. Several minor bugs in test helper functions were also fixed, and type checker warnings have been addressed by adding type: ignore comments.

The changes are generally positive and improve the quality of the test code. I've pointed out a few minor areas for improvement related to redundant type: ignore comments and an unnecessary pylint directive.

[gemini-code-assist]

The pylint: disable=redefined-builtin comment is no longer necessary and is misleading. It was applicable when the parameter was named str, which shadows a built-in. Since you've renamed the parameter to test (which is not a built-in), this disable directive can be removed.

Suggested change

	def str2bool(test): # pylint: disable=redefined-builtin
	def str2bool(test):

[gemini-code-assist]

There seems to be a redundant type: ignore. The # type: ignore[index] on line 157 applies to the following line (158), but line 158 already has an inline # type: ignore[index]. You can remove the comment on line 157 to avoid this duplication.

Suggested change

	# type: ignore[index]
	choices = msg_resp_obj["output"]["choices"] # type: ignore[index]
	choices = msg_resp_obj["output"]["choices"] # type: ignore[index]

[gemini-code-assist]

Similar to a previous comment, there is a redundant type: ignore here. The # type: ignore[index] on line 184 can be removed as line 185 already has an inline ignore.

Suggested change

	# type: ignore[index]
	choices = msg_resp_obj["output"]["choices"] # type: ignore[index]
	choices = msg_resp_obj["output"]["choices"] # type: ignore[index]

[gemini-code-assist]

There's a redundant type: ignore here as well. You can remove the # type: ignore[index] on line 211.

Suggested change

	# type: ignore[index]
	choices = msg_resp_obj["output"]["choices"] # type: ignore[index]
	choices = msg_resp_obj["output"]["choices"] # type: ignore[index]