-
Notifications
You must be signed in to change notification settings - Fork 0
Use snapshots instead of custom NFS implementation #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces major improvements to the CI/CD pipeline, containerization, and documentation for the Dappnode staker test utility. It adds dedicated Dockerfiles for each service, automated GitHub Actions workflows for building, testing, and releasing binaries and images, and significantly expands the documentation to help users understand and utilize the toolkit. Additionally, the main entry points for both the test runner and snapshot checker have been refactored for clarity and maintainability.
CI/CD and Containerization Enhancements:
Automated GitHub Actions Workflows
.github/workflows/build-and-push.ymlto build and push Docker images fortest-runnerandsnapshot-checkeron pushes tomainand tags, with matrix builds and caching..github/workflows/release.ymlto build and release cross-platform binaries for both utilities on tagged releases, uploading them as artifacts and attaching them to GitHub Releases.Dockerfile Reorganization
Dockerfileand replaced it with service-specific Dockerfiles:Dockerfile.test-runnerandDockerfile.snapshot-checker, each using multi-stage builds for minimal images and including only necessary dependencies. [1] [2] [3]Documentation Improvements:
README.mdwith detailed usage instructions, environment variable documentation, GitHub Actions integration examples, and feature overviews for both the test runner and snapshot checker.Codebase Refactoring:
cmd/snapshot-checker/main.goas the main entry point for the snapshot checker, including configuration parsing, adapter setup, and signal handling for graceful shutdown.cmd/test-runner/main.go, streamlining configuration parsing, adapter initialization, and improving logging and signal handling.These changes collectively modernize the project's build, release, and deployment process, improve maintainability, and make it easier for users and contributors to run and understand the staker test utilities.