Merged
Conversation
017e57d to
753904a
Compare
753904a to
39bd09d
Compare
jedevc
reviewed
Sep 25, 2025
Contributor
jedevc
left a comment
There was a problem hiding this comment.
SGTM, I'm just conflicted on whether we actually want this as the default.
e.g. if users want to generate their own job summaries, this is actually quite annoying.
Alternatively:
- What if we had an input that was a file path to write the report to?
- What if we had an output that was a file path / raw content of the report?
Then we can control the format and magic generation of the report, while allowing user control over what actually happens to the report.
Contributor
Author
|
That's fair. I haven't really used summaries much. A quick search for a few examples seems like they usually have two options: one for specifying where to write the summary and another one to specify whether to automatically add it to GitHub actions. For example: https://github.com/marketplace/actions/super-linter#summary-outputs. I would do both options as well. So that its easy to automatically add summaries to github without more work than setting an option @jedevc |
55b8d12 to
358d712
Compare
jedevc
approved these changes
Sep 26, 2025
Signed-off-by: Matias Pan <matias@dagger.io>
358d712 to
78920e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a summary for all verbs that run commands. The summary includes the actual dagger command that was executed, a link to the trace and the output of
dagger version. For example: