Open
Conversation
Signed-off-by: Andrea Luzzardi <al@dagger.io>
cwlbraa
reviewed
Jul 3, 2025
|
|
||
| # Quick assessment before merging | ||
| cu diff backend-api`, | ||
| cu diff backend-api -b main`, |
Contributor
There was a problem hiding this comment.
in raw git, isn't this equivalent to git diff main fancy-mallard? or git diff fancy-mallard main we should make sure we're copying that UX wherever possible.
also why does it say backend-api, those are adverb animals lol
Contributor
Author
There was a problem hiding this comment.
cu diff is slightly different than a git diff ... out of the box, it does a git diff $(git merge-base $(git branch --show-current) CU_ENV))..CU_ENV
The -b here is replacing the merge-base stuff with whatever is in -b
Really unsure whether we should copy the syntax or not here, especially since I think we'll want to support paths (like git) and the syntax gets tricky
git diff main fancy-mallard
git diff main..fancy-mallard
git diff main..fancy-mallard ./cmd
git diff main fancy-mallard -- ./cmd
Contributor
Author
There was a problem hiding this comment.
Any opinion from a git UX POV?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-bflag tocu {log,diff}