Fix annotation when a table_name_prefix is in use#1003
Open
clottman wants to merge 1 commit intoctran:developfrom
Open
Fix annotation when a table_name_prefix is in use#1003clottman wants to merge 1 commit intoctran:developfrom
clottman wants to merge 1 commit intoctran:developfrom
Conversation
bark-cmcdonald
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected behavior:
If a table has a table name prefix, I can annotate it.
Current behavior:
Annotation fails because it's trying to use the unprefixed table name when getting the indexes.
Fix explanation
In
retrieve_indexes_from_table, klass.table_name already contains the prefix if one exists. So, we shouldn't need to check separately for the prefixed or unprefixed version.Tests
I tried to add tests; there is one failing and I'm not sure what the expected behavior is there/how to fix it. (Unclear to me if it's a test-specific failure or the fix I am suggesting doesn't work for this particular case).
Related issues
Seems related possibly to #967 and this comment - we were seeing the same error message as that user.