-
Notifications
You must be signed in to change notification settings - Fork 0
Make cairocffi optional: lazy import only when render pipeline is used #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: csett86 <1392875+csett86@users.noreply.github.com>
Co-authored-by: csett86 <1392875+csett86@users.noreply.github.com>
|
|
@copilot Add a separate tox test env with cairo and run the tests that require cairo only there |
Co-authored-by: csett86 <1392875+csett86@users.noreply.github.com>
Added in cf391a1. The tox configuration now has:
|
|
@copilot Rename the extra feature and environment to render |
Co-authored-by: csett86 <1392875+csett86@users.noreply.github.com>
|
@copilot Split the tests in test_render between ones requiring cairo and ones not requiring cairo so that majority of test_render tests are still executed without cairo |
Co-authored-by: csett86 <1392875+csett86@users.noreply.github.com>
Split in 7a90276. Created |
|
@copilot Make the test_http work without cairo |
Co-authored-by: csett86 <1392875+csett86@users.noreply.github.com>
|
@copilot Run the cairo tests also (separately) in github actions workflow |
Co-authored-by: csett86 <1392875+csett86@users.noreply.github.com>
Added in 6eb7c52. Created a new
The job is included in the failure notification dependencies. |
|
@copilot Add it to the test matrix instead of own test job, and no need for any library installation |
Co-authored-by: csett86 <1392875+csett86@users.noreply.github.com>
[cairo]extra in pyproject.tomlOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.