Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
davidabram
force-pushed
the
feat/contact-tests
branch
from
36a1895 to
2579818
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
davidabram
commented
Sep 26, 2025
davidabram
commented
Sep 29, 2025
| await notifyContactCreated(name, email, url); | ||
| } else if (errorMessage) { | ||
| await notifyContactError(name, email, message); | ||
| throw { |
davidabram
commented
Sep 29, 2025
|
|
||
| const statusCode = (error as any).statusCode || 501; | ||
| const message = | ||
| (error as any)?.body?.message || "Issue while processing request"; |
Member
Author
There was a problem hiding this comment.
This isn't a standard error. What is this?
davidabram
commented
Sep 29, 2025
apps/contact/helpers/notion.ts
Outdated
| id: response.id, | ||
| url: response.url, | ||
| }; | ||
| } else if (response.id && !isFullPage(response)) { |
Member
Author
There was a problem hiding this comment.
early return / flatten if else
davidabram
commented
Sep 29, 2025
| } | ||
| } catch (e) { | ||
| return { | ||
| error: "Failed to create notion page", |
davidabram
commented
Sep 29, 2025
| source, | ||
| ); | ||
|
|
||
| if (notionPageId && url) { |
Member
Author
There was a problem hiding this comment.
Early return, figure out what's going on in notion helper.
Ante-Koceic
force-pushed
the
feat/contact-tests
branch
from
3419fba to
6e1f259
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.