Makes the 'val' method set the query silently.#187
Open
nzifnab wants to merge 1 commit intocorejavascript:masterfrom
Open
Makes the 'val' method set the query silently.#187nzifnab wants to merge 1 commit intocorejavascript:masterfrom
nzifnab wants to merge 1 commit intocorejavascript:masterfrom
Conversation
Currently, the only time 'silent' is used when setting the query is in
the default 'select' method; an item is selected, and the value is set
silently such that another query to the autocompleter won't be made. I
believe this should always happen when triggering $element.typeahead('val',
aValue);
When I manually call 'val' on a typeahead object, it is never because I
want to autocomplete a result. It is because I am populating that value
either from a selected dataset (custom render/select method) or from
another source. This redundant querying can cause problems when the
source is a remote that charges per request, for example (mapquest
autocomplete addresses, for one).
If you *truly* want to fill in an input value and trigger an
autocomplete request, use the new 'query' method instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the only time
silentis used when setting the query is inthe default
selectmethod (here: https://github.com/corejavascript/typeahead.js/blob/master/src/typeahead/typeahead.js#L367); an item is selected, and the value is setsilently such that another query to the autocompleter won't be made. I
believe this should always happen when triggering
$element.typeahead('val', aValue);When I manually call
valon a typeahead object, it is never because Iwant to autocomplete a result. It is because I am populating that value
either from a selected dataset (custom render/select method) or from
another source. This redundant querying can cause problems when the
source is a remote that charges per request, for example (mapquest
autocomplete addresses, in my case).
If you truly want to fill in an input value and trigger an
autocomplete request, use the new
querymethod instead.