udp-echo-server: Send the echo response when socket is writable#8
Open
dubek wants to merge 1 commit intocoolaj86:masterfrom
dubek:udp-echo-server-response-when-writable
Open
udp-echo-server: Send the echo response when socket is writable#8dubek wants to merge 1 commit intocoolaj86:masterfrom dubek:udp-echo-server-response-when-writable
dubek wants to merge 1 commit intocoolaj86:masterfrom
dubek:udp-echo-server-response-when-writable
Conversation
Instead of calling sendto() directly from the udp_cb callback (which is called when a new packet is received), prepare a response and tell libev to call our udp_response_cb callback when the socket is writable. This also removes all the global variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of calling
sendto()directly from theudp_cbcallback (which is called when a new packet is received), prepare a response and tell libev to call ourudp_response_cbcallback when the socket is writable.This also removes all the global variables.