Feature: allow providing chunked files for AnimatedTextures#94
Feature: allow providing chunked files for AnimatedTextures#94lincoln-lm wants to merge 1 commit intocontariaa:mainfrom
Conversation
…84px height limit
|
I am very worried about the performance impact of this, have you done any testing regarding load times, memory usage and framerate (on wall or ingame)? Implementation wise I'd prefer adding a |
|
I'm not sure the best way to go about profiling this but in my personal use with a very large animation (2 minutes, 20 fps, 1056x594) I haven't noticed any hiccups, rps drops, or other obvious issues unless the animation is chunked such that the individual .pngs are very large (splitting at a threshold lower than 16384 fixes this). I do think webp or gif support is ideal but it seemed out of my depth wrt java/mc modding. 16384x16384 isn't enough for my particular use case, though I do admit it is likely completely reasonable for more sane packs. |
|
If it works performantly enough for you that seems fine then, if it doesnt work well for other people they just wont be able to make use of this. |
This wouldnt work great with multiple resourcepacks but neither does lock randomization, probably something i'll look at improving in the eventual customization update |
AnimatedTextures currently fail to render properly (
OpenGL debug message, id=1000, source=API, type=ERROR, severity=HIGH, message=glTexImage2D has generated an error (GL_INVALID_VALUE)) when provided textures > 16384 pixels tall. This limits the length of animations based on the resolution of the image. This PR attempts to allow providing multiple animated texture files that will be displayed one after another to get around this limit and allow animated textures of (theoretically) arbitrary length.I am not confident this is the most elegant approach to solving the problem (and storing animated images the way MC does is very inefficient storage-wise) but it was the simplest I could think of.