feat(deparser): add join fixtures for pretty printing tests#280
Closed
pyramation wants to merge 1 commit intomainfrom
Closed
feat(deparser): add join fixtures for pretty printing tests#280pyramation wants to merge 1 commit intomainfrom
pyramation wants to merge 1 commit intomainfrom
Conversation
Add SQL fixtures for testing JOIN parsing and deparsing: - Simple inner join - Left outer join - Multiple joins - Joined tables with specific columns - Raw ast passthrough These fixtures help verify that JOIN statements are parsed and deparsed correctly.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(deparser): add join fixtures for pretty printing tests
Summary
Adds SQL fixtures for testing JOIN statement parsing and deparsing. These fixtures were extracted from snapshots in another repository and cleaned up (removed unnecessary quotes around column references like
"t0.id"→t0.id).The fixtures cover:
Review & Testing Checklist for Human
"t0.id"which I converted to propert0.idsyntax. If you wanted to test the quoted versions to investigate a potential parser bug, those should be added separately.INNER JOIN→JOIN,LEFT OUTER JOIN→LEFT JOIN)npm test -- --testPathPatterns="joins-pretty"inpackages/deparserto verify tests passNotes