Skip to content

fix(graphile-cache): remove redundant serv.release() to prevent double-release error #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyramation merged 2 commits into from
Feb 5, 2026
Merged

fix(graphile-cache): remove redundant serv.release() to prevent double-release error #685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfc1ce3
fix(graphile-cache): remove redundant serv.release() to prevent doubl…
pyramation Feb 5, 2026
611dec9
docs: update disposeEntry docstring to reflect removal of explicit se…
pyramation Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions graphile/graphile-cache/src/graphile-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,8 @@ const manualEvictionKeys = new Set<string>();
* Dispose a PostGraphile v5 cache entry
*
* Properly releases resources by:
* 1. Releasing the grafserv instance
* 2. Closing the HTTP server if listening
* 3. Releasing the PostGraphile instance
* 1. Closing the HTTP server if listening
* 2. Releasing the PostGraphile instance (which internally releases grafserv)
*
* Uses disposedKeys set to prevent double-disposal when closeAllCaches()
* explicitly disposes entries and then clear() triggers the dispose callback.
Expand All @@ -114,17 +113,13 @@ const disposeEntry = async (entry: GraphileCacheEntry, key: string): Promise<voi

log.debug(`Disposing PostGraphile[${key}]`);
try {
// Release grafserv first
if (entry.serv) {
await entry.serv.release();
}
// Close HTTP server if it's listening
if (entry.httpServer?.listening) {
await new Promise<void>((resolve) => {
entry.httpServer.close(() => resolve());
});
}
// Release PostGraphile instance
// Release PostGraphile instance (this also releases grafserv internally)
if (entry.pgl) {
await entry.pgl.release();
}
Expand Down