feature: update function to handle localhost properly#667
Open
feature: update function to handle localhost properly#667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
send-email-linkfunction to improve local development flexibility and configuration. The primary change is to introduce a newALLOW_LOCALHOSTenvironment variable, which enables the use ofhttpand custom ports for localhost URLs, replacing the previous logic that relied on dry-run mode. This allows for safer and more intentional local testing. Additionally, the handling of theLOCAL_APP_PORTenvironment variable is streamlined.Configuration and Local Development Improvements:
ALLOW_LOCALHOSTenvironment variable to explicitly enablehttpprotocol and custom ports for localhost URLs, decoupling this behavior from dry-run mode. (functions/send-email-link/src/index.ts)ALLOW_LOCALHOSTandLOCAL_APP_PORTinstead of relying on dry-run mode, improving clarity and control for local development. (functions/send-email-link/src/index.ts)allowLocalhostin the logger output and standardized the use of thelocalAppPortvariable for reporting, ensuring consistency in diagnostics and debugging. (functions/send-email-link/src/index.ts)