Add GCP support in connect artifact commands#3255
Open
hisingla12 wants to merge 2 commits intomainfrom
Open
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull request overview
This PR adds support for Google Cloud Platform (GCP) in the connect artifact commands, expanding the CLI's cloud provider capabilities beyond AWS and Azure.
Changes:
- Updated connect artifact commands (create, list, describe, delete) to support GCP cloud provider
- Added comprehensive test coverage for GCP artifact operations including JAR and ZIP formats
- Updated validation logic and error messages to include GCP as a supported cloud provider
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/connect/command_artifact_create.go | Added GCP to supported clouds list, updated error message, and implemented GCP-specific upload logic |
| internal/connect/command_artifact_list.go | Changed flag from AWS/Azure-specific to generic cloud flag |
| internal/connect/command_artifact_describe.go | Changed flag from AWS/Azure-specific to generic cloud flag |
| internal/connect/command_artifact_delete.go | Changed flag from AWS/Azure-specific to generic cloud flag |
| test/connect_test.go | Added comprehensive test cases for GCP artifact operations (create, list, describe, delete) |
| test/test-server/connect_handler.go | Added GCP test artifacts and updated handlers to recognize GCP artifact IDs |
| test/fixtures/output/connect/artifact/*.golden | Added golden files for GCP artifact operation outputs in various formats (table, JSON, YAML) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Breaking Changes
New Features
Bug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Blast Radius
References
Test & Review