Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|
There was a problem hiding this comment.
Pull request overview
This PR adds support for two new Flink connection types: "cosmosdb" and "s3vectors" to the Confluent CLI. The changes enable users to create and manage connections to Azure Cosmos DB using API keys and AWS S3 Vectors using AWS credentials.
Changes:
- Added "cosmosdb" and "s3vectors" to the list of supported connection types
- Updated authentication parameter mappings for both new connection types
- Added test cases and golden fixtures for the new connection types
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/flink_test.go | Added test cases for creating cosmosdb and s3vectors connections |
| test/fixtures/output/flink/connection/create/create-s3vectors.golden | Golden file showing expected output for s3vectors connection creation |
| test/fixtures/output/flink/connection/create/create-cosmosdb.golden | Golden file showing expected output for cosmosdb connection creation |
| test/fixtures/output/flink/connection/*.golden | Updated help text and error messages to include new connection types |
| pkg/flink/utils.go | Added cosmosdb and s3vectors to connection type mappings and authentication configurations |
| cmd/lint/main.go | Added new connection type names to vocabulary whitelist |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.





Release Notes
New Features
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Add new flink s3vectors connection, this pr applies to CC.
Blast Radius
Minimal. This additive change should only affect new s3vectors type connection introduced by this PR.
References
Test & Review