Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|
There was a problem hiding this comment.
Pull request overview
This PR adds support for a new Flink connection type, cosmosdb, in the CLI and updates associated tests and help text. It ensures the new type is wired into connection type validation, secret handling, and command help output.
Changes:
- Extend core Flink connection utilities to recognize
cosmosdband associate it withapi-keysecrets. - Add and update CLI tests and golden files (create, list, update, and error/help outputs) to cover the
cosmosdbconnection type. - Update the linting vocabulary to allow the new
cosmosdbidentifier.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/flink_test.go | Adds a successful Flink connection create test case for the new cosmosdb type. |
| test/fixtures/output/flink/connection/update-help.golden | Updates update-help output to include cosmosdb in the list of types using --api-key. |
| test/fixtures/output/flink/connection/list/list-failure.golden | Extends invalid-type suggestion output to mention cosmosdb. |
| test/fixtures/output/flink/connection/list-help.golden | Updates list-help output to include cosmosdb in the --type flag description. |
| test/fixtures/output/flink/connection/create/create-wrong-type.golden | Extends wrong-type suggestion output to mention cosmosdb. |
| test/fixtures/output/flink/connection/create/create-rest-mutually-exclusive-secret.golden | Updates create-help output for REST mutual exclusivity to include cosmosdb in type and --api-key descriptions. |
| test/fixtures/output/flink/connection/create/create-rest-missing-required-secret.golden | Updates missing-secret create-help output to include cosmosdb where relevant. |
| test/fixtures/output/flink/connection/create/create-missing-required-secret.golden | Adds cosmosdb to the type and --api-key descriptions in missing-secret messaging. |
| test/fixtures/output/flink/connection/create/create-mcp_server-mutually-exclusive-secret.golden | Adjusts mcp_server mutual-exclusive-secret help to include cosmosdb in shared lists. |
| test/fixtures/output/flink/connection/create/create-mcp_server-missing-required-secret.golden | Updates mcp_server missing-secret help text to mention cosmosdb. |
| test/fixtures/output/flink/connection/create/create-cosmosdb.golden | Adds golden output for a successful cosmosdb Flink connection creation. |
| test/fixtures/output/flink/connection/create/create-a2a-mutually-exclusive-secret.golden | Extends a2a mutual-exclusive-secret help output to include cosmosdb in shared lists. |
| test/fixtures/output/flink/connection/create/create-a2a-missing-required-secret.golden | Updates a2a missing-secret help text to reference cosmosdb. |
| test/fixtures/output/flink/connection/create-help.golden | Updates generic create-help output to include cosmosdb in type and --api-key descriptions. |
| pkg/flink/utils.go | Registers cosmosdb in connection types and secret mappings, including required api-key. |
| cmd/lint/main.go | Adds cosmosdb to the linter vocabulary list to avoid false-positive spelling issues. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.





Release Notes
New Features
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Add new flink cosmosdb connection, this pr applies to CC.
Blast Radius
this should only affect new cosmosdb type connection
References
Test & Review