Skip to content

[MATRIX-1310] add cosmosdb connection#3251

Merged
sgagniere merged 2 commits intomainfrom
add-new-connection-cosmosdb
Feb 6, 2026
Merged

[MATRIX-1310] add cosmosdb connection#3251
sgagniere merged 2 commits intomainfrom
add-new-connection-cosmosdb

Conversation

@xli1996
Copy link
Member

@xli1996 xli1996 commented Jan 28, 2026

Release Notes

New Features

  • Add "cosmosdb" connection type support for confluent flink connection

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Confluent Platform
    • Check this box if the feature is enabled for certain organizations only

What

Add new flink cosmosdb connection, this pr applies to CC.

Blast Radius

this should only affect new cosmosdb type connection

References

Test & Review

Screenshot 2026-01-28 at 2 41 45 PM

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@xli1996 xli1996 marked this pull request as ready for review January 29, 2026 00:22
@xli1996 xli1996 requested a review from a team as a code owner January 29, 2026 00:22
Copilot AI review requested due to automatic review settings January 29, 2026 00:22
@sonarqube-confluent
Copy link

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for a new Flink connection type, cosmosdb, in the CLI and updates associated tests and help text. It ensures the new type is wired into connection type validation, secret handling, and command help output.

Changes:

  • Extend core Flink connection utilities to recognize cosmosdb and associate it with api-key secrets.
  • Add and update CLI tests and golden files (create, list, update, and error/help outputs) to cover the cosmosdb connection type.
  • Update the linting vocabulary to allow the new cosmosdb identifier.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/flink_test.go Adds a successful Flink connection create test case for the new cosmosdb type.
test/fixtures/output/flink/connection/update-help.golden Updates update-help output to include cosmosdb in the list of types using --api-key.
test/fixtures/output/flink/connection/list/list-failure.golden Extends invalid-type suggestion output to mention cosmosdb.
test/fixtures/output/flink/connection/list-help.golden Updates list-help output to include cosmosdb in the --type flag description.
test/fixtures/output/flink/connection/create/create-wrong-type.golden Extends wrong-type suggestion output to mention cosmosdb.
test/fixtures/output/flink/connection/create/create-rest-mutually-exclusive-secret.golden Updates create-help output for REST mutual exclusivity to include cosmosdb in type and --api-key descriptions.
test/fixtures/output/flink/connection/create/create-rest-missing-required-secret.golden Updates missing-secret create-help output to include cosmosdb where relevant.
test/fixtures/output/flink/connection/create/create-missing-required-secret.golden Adds cosmosdb to the type and --api-key descriptions in missing-secret messaging.
test/fixtures/output/flink/connection/create/create-mcp_server-mutually-exclusive-secret.golden Adjusts mcp_server mutual-exclusive-secret help to include cosmosdb in shared lists.
test/fixtures/output/flink/connection/create/create-mcp_server-missing-required-secret.golden Updates mcp_server missing-secret help text to mention cosmosdb.
test/fixtures/output/flink/connection/create/create-cosmosdb.golden Adds golden output for a successful cosmosdb Flink connection creation.
test/fixtures/output/flink/connection/create/create-a2a-mutually-exclusive-secret.golden Extends a2a mutual-exclusive-secret help output to include cosmosdb in shared lists.
test/fixtures/output/flink/connection/create/create-a2a-missing-required-secret.golden Updates a2a missing-secret help text to reference cosmosdb.
test/fixtures/output/flink/connection/create-help.golden Updates generic create-help output to include cosmosdb in type and --api-key descriptions.
pkg/flink/utils.go Registers cosmosdb in connection types and secret mappings, including required api-key.
cmd/lint/main.go Adds cosmosdb to the linter vocabulary list to avoid false-positive spelling issues.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sgagniere sgagniere merged commit deed534 into main Feb 6, 2026
7 of 9 checks passed
@sgagniere sgagniere deleted the add-new-connection-cosmosdb branch February 6, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants