Implement Upgrade Suggestions for Kafka Cluster Creation in the Confluent CLI#3075
Open
danielayaz wants to merge 4 commits intomainfrom
Open
Implement Upgrade Suggestions for Kafka Cluster Creation in the Confluent CLI#3075danielayaz wants to merge 4 commits intomainfrom
danielayaz wants to merge 4 commits intomainfrom
Conversation
…cluster and upgrading stream governance of an environment from essentials to advanced.
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
| return nil | ||
| } | ||
|
|
||
| copyManager, err := NewCopyManager() |
There was a problem hiding this comment.
Consider logging or handling the error from NewCopyManager instead of silently returning nil, so that issues with loading upgrade suggestions can be diagnosed.
| return nil | ||
| } | ||
|
|
||
| content, cta, err := copyManager.GetCopy("cluster_upgrade_basic_to_standard") |
There was a problem hiding this comment.
Consider logging or handling the error from GetCopy rather than returning nil, which will help in troubleshooting if the upgrade suggestion copy fails to load.
Member
Author
|
Curious as to how acceptance testing works for this kind of scenario where you're doing an A/B test (some percent of orgs will see a certain output in the CLI vs. others) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Breaking Changes
New Features
Bug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Added a feature-flagged upgrade suggestion that appears after creating a Basic Kafka cluster, encouraging users to upgrade to Standard. The suggestion is shown to 85% of organizations and includes specific limitations of Basic clusters with a direct upgrade command.
Blast Radius
If the feature flag service is unavailable or the upgrade suggestion fails, users will simply not see the suggestion message. No core functionality is affected - users can still create and use their clusters normally.
References
https://confluentinc.atlassian.net/browse/CLI-3502
https://app.launchdarkly.com/projects/cli/flags/cli.basic-to-standard-cluster-upgrade-suggestion/targeting?env=production&env=test&selected-env=production
Test & Review
Feature flag ON:
Feature flag OFF:
