Skip to content

Conversation

@belledw
Copy link
Collaborator

@belledw belledw commented Jan 24, 2026

Change Summary

  • Created a member page at /members/{id} to display information about active members of the club.
  • An error is raised if the member is not marked as active, so that id is treated as invalid.
  • Page heading displays member name, pronouns, bio and profile image fetched from backend.
  • Body of page contains widgets for games and artwork the member has contributed to, not yet fetched from backend.

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation - not sure if needed.

Other Information

[Is there anything in particular in the review that I should be aware of?]

Related issue

KKatariah and others added 30 commits January 10, 2026 04:41
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the source for this image? Are we sure we have the rights to use it?

(An SVG is preferable if possible)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image is directly from the Figma design, so I assumed it is ok to use - but will remove if not.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately Lauren has said they just pulled it from the web. We can't know if it's allowed. We'll have to use something that we know we have the rights to use.

@laurenpudz
Copy link
Contributor

Could you please add screenshots of any UI changes to the PR? thanks :)

@belledw
Copy link
Collaborator Author

belledw commented Jan 25, 2026

Here is the updated UI:
Member Profile Page UI 25-01
It is mostly the same as the original PR, but the placeholders in the projects section have been removed.

Copy link
Collaborator

@SafetyInObscurity SafetyInObscurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good folks, but again, we don't know the rights for the frame pixel art so we will need to use something that is known to be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Member pages

6 participants