-
Notifications
You must be signed in to change notification settings - Fork 3
Issue 10 member pages #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…auses/game-dev into issue-10-Member_pages
…plate but idk what im doing
…from "idk bruh merge conflict"
…orrectly displays data
…auses/game-dev into issue-10-Member_pages
…auses/game-dev into issue-10-Member_pages
…fied member profile spacing
client/public/frame.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the source for this image? Are we sure we have the rights to use it?
(An SVG is preferable if possible)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image is directly from the Figma design, so I assumed it is ok to use - but will remove if not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately Lauren has said they just pulled it from the web. We can't know if it's allowed. We'll have to use something that we know we have the rights to use.
… sanitised correct input
|
Could you please add screenshots of any UI changes to the PR? thanks :) |
SafetyInObscurity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good folks, but again, we don't know the rights for the frame pixel art so we will need to use something that is known to be ok.

Change Summary
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
[Is there anything in particular in the review that I should be aware of?]
Related issue