Add proxy log file cleanup #736
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up old coder-ssh-*.log files when count exceeds 20 and files are older than 7 days. Uses mtime-based sorting to delete oldest stale files first.
EhabY
force-pushed
the
cleanup-old-log-files
branch
from
25684d1 to
128754a
Compare
mtojek
approved these changes
Jan 21, 2026
| const stats = await fs.stat(path.join(logDir, name)); | ||
| return { name, mtime: stats.mtime.getTime() }; | ||
| } catch { | ||
| return null; |
Member
There was a problem hiding this comment.
if there is any weird permission denied error, wouldn't this be an issue?
Collaborator
Author
There was a problem hiding this comment.
It would be swallowed yes, I'm not sure I wanna log these 🤔
| const now = Date.now(); | ||
| const files = await fs.readdir(logDir); | ||
|
|
||
| const withStats = await Promise.all( |
Member
There was a problem hiding this comment.
I believe that in a typical setup, we will have max 20 log files? no way we will need a handle 100+ = 100 x fs.stat in parallel
Collaborator
Author
There was a problem hiding this comment.
The files themselves have timestamps in the name, would it make sense to delete based on the filename only? They are named based on the creation but not necessarily when they were last modified so that's why I settled for this. Potentially we can just sort, delete until there's 20 left
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
coder-ssh-*.log) in the proxy log directoryFixed #377