fix: remove unnecessary sentry capture for expected user input errors #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReportEmptyError and ReportExpiredException are expected user input validation issues (customer uploaded empty or expired reports). These were being sent to Sentry via capture_exception() creating ~150K+ error events per week, even though they are already properly logged and handled. This change removes the sentry_sdk.capture_exception() calls for these expected cases while keeping the warning/info logs for debugging.
drazisil-codecov
force-pushed
the
joebecher/reduce-sentry-noise-expected-errors
branch
from
e0dd840 to
295d1d6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
==========================================
- Coverage 93.78% 93.78% -0.01%
==========================================
Files 1291 1291
Lines 46907 46905 -2
Branches 1517 1517
==========================================
- Hits 43991 43989 -2
Misses 2607 2607
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes
sentry_sdk.capture_exception()calls forReportEmptyErrorandReportExpiredException- these are expected user input validation issues that don't need to be tracked as errors in Sentry.Fixes:
Problem
These exceptions were being sent to Sentry creating ~150K+ error events per week:
ReportEmptyError: Customer uploaded empty/invalid reportReportExpiredException: Customer uploaded expired reportThese are already:
Solution
Remove the unnecessary
capture_exception()calls while keeping all logging and error handling intact.Impact
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.